-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all 'directly' regulates relations to just 'regulates' relations #392
Comments
There are currently 23 GO-CAMs on the production servers using directly regulates & children:
For models on the dev server, it's quite a different story with currently 858 models using those relations, including reactome models:
For reference, SPARQL query: https://api.triplydb.com/s/GfM68R29y |
Thank you @lpalbou ! |
@lpalbou |
Even if that's a little confusing, note we have two types of dev:
This query https://api.triplydb.com/s/u9bAgCP2D would for instance also show the state (prod or dev model) as well as the title. To get that information from the prod server, you have to target: http://rdf.geneontology.org/blazegraph/sparql It's unfortunately poorly documented, but at least now it's written somewhere (hopefully) clearly. PS: the same applies for #391 |
Okay, I think I've got it. |
We also need to talk about using the RO subset tags to populate relations in Noctua. Curators find, and use, too many relations not in the GO-CAM specs. |
Note: we will also need to remove these relations from the Noctua graph editor relations drop down (maybe we can only remove them from the top of the list right now?) so curators don't use them once we've updated the existing data. In the future, we should make use of RO subsets for GO-CAM relations. |
|
@thomaspd @tmushayahama @ukemi @cmungall On the Alliance Pathway views, we distinguish between direct and indirect regulation by the type of line between nodes. If we switch over to just using 'regulates' relations we should only have one type of line and change the Alliance display accordingly. I just want to double-check that this is the desired outcome wrt Alliance Pathway views. Here's an example of a model we currently display where solid lines denote direct regulation and dashed lines indirect regulation: |
Most recent list (from 2022-05-25) of GO-CAMs that use 'directly regulates' and 'regulates' relations. |
After discussions about causal MF relations and a new proposal, this change is no longer needed. |
For existing GO-CAM models we want to update any 'directly' regulates relations (and positive/negative children) to just use 'regulates' relations (and positive/negative children).
Note that we'll also want to check for use of 'directly activates' and 'directly inhibits'.
See also: geneontology/go-shapes#255
The text was updated successfully, but these errors were encountered: