Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test mock ontology term replacement for new SOP (II) #479

Closed
kltm opened this issue Apr 27, 2022 · 17 comments
Closed

Test mock ontology term replacement for new SOP (II) #479

kltm opened this issue Apr 27, 2022 · 17 comments

Comments

@kltm
Copy link
Member

kltm commented Apr 27, 2022

A follow on from #476

A place to put results and discussion of the second mock run of the new minerva outage SOP.

Related to #456
Tagging @vanaukenk @balhoff

@kltm
Copy link
Member Author

kltm commented Apr 27, 2022

@kltm
Copy link
Member Author

kltm commented Apr 27, 2022

@vanaukenk
Copy link

vanaukenk commented Apr 28, 2022

@kltm @balhoff @ukemi
In the latest diff, I'm seeing EMAPA:16647 being replaced with UBERON:0034876.
Is this a case where the EMAPA term was made obsolete and is only available now as an UBERON term?

@vanaukenk
Copy link

@kltm - there are other aspects of the diffs that I'm not clear on. If you have time to review today, that'd be helpful. Either during the meeting break of after 3:30pm EDT is good.

@ukemi
Copy link

ukemi commented Apr 28, 2022

Hmmmmm. Seems like a problem:
EMAPA:16627 somite 27 sclerotome
EMAPA:16647 is an xref to UBERON:0034876 and as near as I can see should not have been replaced. It's 'live' in MGI.

@vanaukenk
Copy link

Sorry, my mistake. It's EMAPA:16647 but the question still stands. I'll edit above.

@ukemi
Copy link

ukemi commented Apr 28, 2022

As near as I can tell, it should not have been replaced.

@ukemi
Copy link

ukemi commented Apr 28, 2022

Perhaps a rule to never replace a term from one ontology with another unless reviewed by a curator.

@balhoff
Copy link
Member

balhoff commented Apr 28, 2022

This term was deprecated within Uberon for some reason. This is definitely a bug in Uberon and shouldn't have happened. I'll file a bug there. We shouldn't run this update.

@balhoff
Copy link
Member

balhoff commented Apr 28, 2022

obophenotype/uberon#2440

@kltm
Copy link
Member Author

kltm commented Apr 28, 2022

@balhoff Possibly related question: does minerva do replace operations when replaced_by is present during any other operations, or is it only considered when we do the bulk updates? For example, if during "normal" editorial operations I did something with an obsolete term, would minerva ever attempt to replace it?

@balhoff
Copy link
Member

balhoff commented Apr 28, 2022

No. It used to do some automatic replacement to calculate root types for nodes (but not changing the data), but I removed this in the recent performance-improvement PRs.

@kltm
Copy link
Member Author

kltm commented Apr 28, 2022

@balhoff Okay great! Something was kicking around in my head about that--thank you for clarifying.

After talking to @vanaukenk we'll go ahead with a reduced SOP today, just: power down, flush, save, remove ontology journal, restart (and have ontology journal build back up).

@vanaukenk
Copy link

I've added this issue to the 2022-05-02 ontology call; we may also want to discuss on a manager's call.

@vanaukenk
Copy link

@balhoff @kltm
I'm checking in about our Noctua outage this coming Thursday, the 14th.

From the ticket in the UBERON tracker, it looks like the specific EMAPA issue we encountered has now been fixed.

Is there anything more we need to do on our end?

I'm assuming we'll do another draft replacement sometime this week so I can check the pending changes before we move ahead with an update on production Noctua.

Thanks.

@balhoff
Copy link
Member

balhoff commented May 9, 2022

I think we need to wait for the next Uberon release. I can ask when the next will be.

@kltm
Copy link
Member Author

kltm commented May 12, 2022

Replaced by #483

@kltm kltm closed this as completed May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants