-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mock run of new (proposed) SOP noctua-model replacement and updates #483
Comments
@vanaukenk It would be good to decide on a standard commit message for relation updates. |
@balhoff In your example given at https://github.com/geneontology/minerva/pull/478/files#diff-aefb43779e951b6f961416f1195b5d9b753eca8a12a29f64a7a2cd8fb432e63dR226, you have a file |
@kltm I'm thinking that it might be useful to have a generic commit message for any changes that are not made using a 'replaced by' tag in an ontology. How about: "Automated change YYYY-MM-DD: CURIE:xxxxxxx updated to CURIE:yyyyyyy" ? |
@vanaukenk We can't really have variables in a git commit message in this case as it is for the entire code tree at that moment in time, rather than individual files, so individual CURIEs would not make much sense. |
@kltm - I thought you were referring to the actual comment in the models (where I'm still wondering if we should use 'replaced by' for these relations updates since that has a specific meaning in ontologies.. @balhoff - any thoughts?) For a git commit message, then, how about: I am open to suggestions here, if there's something you and @balhoff think would be more informative or appropriate. |
@vanaukenk Sounds good to me. I think my only comment would be something a step outward: geneontology/noctua-models#233 (comment) |
…; now in repo noctua-models-migrations
Yes that is to be able to replace classes as well as relations. We should just create an empty file alongside the relations one for now. |
Thank you for the clarification @balhoff ; I've updated the SOP. |
@vanaukenk A |
This is to be a standing ticket to support and discuss mock runs of current and proposed SOPs for https://github.com/orgs/geneontology/projects/87 . The reason to consolidate is to 1) make it look more like how it will be run in the future and 2) prevent the proliferation of expensive branches of noctua-models. Currently, we'll be testing:
Replaces #479 and #476 .
The text was updated successfully, but these errors were encountered: