Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprint 1 #201

Merged
merged 10 commits into from
Jul 21, 2022
Merged

Sprint 1 #201

merged 10 commits into from
Jul 21, 2022

Conversation

tmushayahama
Copy link
Collaborator

Issues

#162
#185
geneontology/noctua-landing-page#47
#177

Added

  • Announcement Banner Sample

Changed

  • Fix Evidence getting lost after adding an input
  • Added Uberon Life Stages on the happens during
  • Activity Date now taking the last modified individua or evidence

Testing

tagging @vanaukenk @ukemi

@tmushayahama tmushayahama merged commit 438362e into dev Jul 21, 2022
@vanaukenk
Copy link

#162 #185 #177 are tested and okay to move to production, but the announcements ticket needs more discussion and isn't ready to move to production.
@tmushayahama can you re-submit the PR without the announcements work/addition?

@tmushayahama
Copy link
Collaborator Author

@vanaukenk oh yes, it will not show up on production . This is only for dev.

@vanaukenk
Copy link

@tmushayahama
But can we move the work for #162 #185 and #177 to production Noctua without also putting the announcements work into production?
I've tested and approved those three tickets for production, but don't want to put the announcements onto production yet.

@tmushayahama
Copy link
Collaborator Author

@vanaukenk yes, that what I meant on above. The production will not have the announcement components displaying. The code is for the dev server now, but not for production. I am about to PR to production

@vanaukenk
Copy link

See: #202

@tmushayahama
Copy link
Collaborator Author

@vanaukenk that's PR to production without the announcements .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants