Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not working filter on noctua new landing page search panel #12

Open
LiNiMGI opened this issue Apr 22, 2020 · 8 comments
Open

not working filter on noctua new landing page search panel #12

LiNiMGI opened this issue Apr 22, 2020 · 8 comments

Comments

@LiNiMGI
Copy link

LiNiMGI commented Apr 22, 2020

I am using mac/firefox, here are some of the filters that didn't work when I tested:

filter by reference
fliter by date/date range
filter by title

Thanks,
Li

@tmushayahama
Copy link
Collaborator

@LiNiMGI thanks for testing. Can you attach a screenshot. I just tested on firefox and it seems to be filtering
image

@LiNiMGI
Copy link
Author

LiNiMGI commented Apr 23, 2020

@tmushayahama here is the screenshot.
Screen Shot 2020-04-22 at 10 05 36 PM

@tmushayahama
Copy link
Collaborator

Hi @LiNiMGI you have to press enter for each textbox (search input) after finishing typing. We haven't written any documentation yet and it might be confusing. It allows multiple values, like putting more than one reference. I have created a 20 second gif animation below

filter

@vanaukenk can explain more on a specific use case

@vanaukenk
Copy link

vanaukenk commented Apr 23, 2020

@tmushayahama
For some search fields, e.g. Term and Gene Product, the filtering happens automatically without having to press enter/return.
But for other fields, e.g. Reference, you do have to press enter/return.
Is there a technical reason for the difference?

@LiNiMGI
Copy link
Author

LiNiMGI commented Apr 23, 2020

Thanks @tmushayahama !
yes, both "filter by reference" and "fliter by date/date range" works after press enter :)

FYI:
for the "filter by title" search, it pull out more models than I want...
see screenshot below:
Screen Shot 2020-04-23 at 10 43 16 AM

when I use the exact title "enabled by Tespa1 Mmus" to search, I got 188 results
when I only use "Tespa1" to search, I got one result and it's the right model

Maybe "filter by title" search was set up this way?

Thanks again,
Li

@vanaukenk
Copy link

Perhaps we'll want an 'Exact Match' option on the title search where 'Exact Match' would mean the title needs to include the entire search value?
Right now, if I search the Title field with 'gcy-8' I'm getting models returned that have '8' in the title and that's not what I'd want.

@tmushayahama
Copy link
Collaborator

@tmushayahama
For some search fields, e.g. Term and Gene Product, the filtering happens automatically without having to press enter/return.
But for other fields, e.g. Reference, you do have to press enter/return.
Is there a technical reason for the difference?

@vanaukenk
for the other fields like term, Group, Contributor, GP, the values are autocompletable and the exact search input is know. However on a free text like title and reference, it has to be manual. Live search will be expensive i.e. to search after every keystroke

@goodb
Copy link

goodb commented Apr 23, 2020

@tmushayahama @kltm if/when geneontology/minerva#310 is accepted, the exact match search (ie search without *s ) should work more like expected. Let me know if this solves the problem here. Thanks to @balhoff .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants