Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support darwin-arm64 #2

Closed
docgonzo2015 opened this issue Jan 29, 2022 · 7 comments · Fixed by #11
Closed

Support darwin-arm64 #2

docgonzo2015 opened this issue Jan 29, 2022 · 7 comments · Fixed by #11

Comments

@docgonzo2015
Copy link

No description provided.

@gennaro-tedesco
Copy link
Owner

The distributions releases are built automatically by this GitHub action and I do see that darwin/arm64 is in fact missing. Looking around here and here it seems that this discussion is in place in Go as a whole (so not available yet).

If you however do have pointers on how this can be achieved manually I would be happy to look into it (I am not an expert on the matter myself, so I am reading around to see how to achieve it)!

@seachicken
Copy link
Contributor

@gennaro-tedesco
Copy link
Owner

Thank you for pointing to the right direction! I would personally prefer to wait for a new version to be released: this is because then we would be dependent on an additional dependency, it being Goreleaser. What has been your experience with it? From the snippet you provided I take it is just a matter of changing the action file workflow?

@seachicken
Copy link
Contributor

In order for Goreleaser to work, you need to add GitHub Actions and yml.
https://github.com/seachicken/gh-poi/blob/main/.goreleaser.yml

I've been using this for a few months now and it seems to work perfectly fine.
However, I would like to use what the official version provides as much as possible, so I will replace it when the cli/gh-extension-precompile is upgraded. Until then, it's not a bad alternative.

@gennaro-tedesco
Copy link
Owner

Again thank you for the complete set of instructions :).

Since I do not own a darwin-arm64 architecture I would need someone to help test on theirs that the produced release works. So for anyone passing by this issue with such system, feel free to open a PR.

This was referenced Feb 1, 2022
@gennaro-tedesco
Copy link
Owner

Courtesy of @seachicken now v0.0.4 has support for darwin-arm64 too.

@docgonzo2015 would you try to see if it works for you too?

@mislav
Copy link

mislav commented Apr 13, 2022

The latest GitHub CLI 2.8.0 release fixes this by falling back to amd64 binary if Rosetta is installed. If an arm64 binary is found, for example as a product of the latest gh-extension-precompile action, however, then its codesigning is fixed after downloading to allow execution by the OS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants