Superlatives

[vineyardbovines]

I'm not sure which module this would fall under, but it seems that superlatives of words aren't caught- at least in the case of this word here. Technically, this word is grammatically correct.

To tack onto this, the two rules caught with this particular word seem a little confusing. The first one tells me it 'may be insensitive', and the second one tells me it's profane. Which is it? 😅

[wooorm]

@gretzky Sorry for the slow reply. To get a new profanity in there, you need to PR to profanities, and then when that’s released, to cuss. Then it’ll be automatically in retext-profanities and alex as well!

for the duplicate warnings, that could be another issue, to ignore profanities if they’re already warned about in equality.

[wooorm]

@gretzky Would you be into creating a PR for the first case, and open another issue for the second?

[vineyardbovines]

Sure I'll take a crack at it

[vineyardbovines]

@wooorm so rather than just adding a new word, i wrote a small tool that formats comparatives / superlatives. hopefully this is helpful in identifying several words. i can always add the individual word if that's easier, but i figured there's a use case out there that would need to check for multiple comparatives or superlatives of profane word.

[wooorm]

@gretzky That is very nice! However, when you say “small”, it actually uses words/brill which is 1.8mb minified! I’m not sure it’s a great idea to add so much more code to alex! 🙀

[vineyardbovines]

Got it! FWIW, I removed brill. Either way, I can add the words manually if that's what you think we should do here!

[wooorm]

@gretzky Heyy, very slow I know, but I was working on implementing this right now, but saw the package isn’t on npm!

[wooorm]

I cloned it locally, updated to syllable 4.0.0, and published to npm as 0.1.0, so I can start to work on it! What’s your npm username? I’d love to give it back to you, looks very useful

[vineyardbovines]

Sorry I didn't see this before, my npm username is gretzky...yeah I would definitely love to have my package back. Not sure why you couldn't have just forked it though...?

[wooorm]

You are added and I removed myself!

Whether to fork or not doesn’t make a difference in this case?
Whether to publish or not: I expected the package to work and be published, and I wanted to release a new version of alex to solve this issue using your package.

[vineyardbovines]

Cool thanks! Yeah I didn't realize it wasn't published, I figured that someone would've just told me to publish it before publishing it themselves. To each their own tho