Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat): make example/otel-jeager work #23

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

schristoff
Copy link
Member

@schristoff schristoff commented Sep 20, 2023

  • We were pulling latest which made everything very mad. Pushed up back to the last week. We need to update otel and friends in Porter - as well as update this example to not be passing in jeager as an exporter.
    Here's how to recreate:
    Use the bundle before this fix. porter install otel-jaeger -r=ghcr.io/getporter/examples/otel-jaeger:v0.1.0 --allow-docker-host-access

Then check your containers, the collector container should be upset - if you get its logs you'll see:

* error decoding 'exporters': unknown type: "jaeger" for id: "jaeger" (valid values: [logging instana otlp azuredataexplorer azuremonitor f5cloud influxdb logicmonitor awskinesis coralogix elasticsearch loadbalancing loki sumologic awscloudwatchlogs awsxray carbon dataset otlphttp alibabacloud_logservice awss3 clickhouse dynatrace googlecloudpubsub kafka parquet zipkin cassandra datadog googlemanagedprometheus logzio prometheus prometheusremotewrite pulsar sapm splunk_hec awsemf file googlecloud opencensus sentry tanzuobservability tencentcloud_logservice mezmo signalfx skywalking])

I think if we update the config we are passing in to not pass in jeager that would solve this, but then leaves the question of what are we supposed to do to configure the two containers (the collector and jeager all in one) to do to talk?

  • helpers.sh didn't have ./ before it in the install which led to this error (users will still have this when pulling pre v0.1.1):
mixin execution failed: package command failed /cnab/app/cnab/app/mixins/exec/runtimes/exec-runtime install
                                /cnab/app helpers.sh set-config
                                couldn't run command /cnab/app helpers.sh set-config: exec: "helpers.sh": executable file not found in $PATH
                                Error: couldn't run command /cnab/app helpers.sh set-config: exec: "helpers.sh": executable file not found in $PATH

@schristoff schristoff changed the title remove latest, update install command (feat): make example/otel-jeager work Sep 20, 2023
@schristoff
Copy link
Member Author

Oh this is pulling the old debian images somewhere

Copy link
Member

@troy0820 troy0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@troy0820
Copy link
Member

Rebase or nah?

@troy0820 troy0820 force-pushed the schristoff_fixoteljeagerimage branch from ced9326 to 8a1d278 Compare September 21, 2023 15:57
@schristoff schristoff merged commit dd72110 into getporter:main Sep 22, 2023
1 of 2 checks passed
@schristoff schristoff deleted the schristoff_fixoteljeagerimage branch September 22, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants