(feat): make example/otel-jeager work #23
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otel
and friends in Porter - as well as update this example to not be passing injeager
as an exporter.Here's how to recreate:
Use the bundle before this fix.
porter install otel-jaeger -r=ghcr.io/getporter/examples/otel-jaeger:v0.1.0 --allow-docker-host-access
Then check your containers, the collector container should be upset - if you get its logs you'll see:
I think if we update the config we are passing in to not pass in
jeager
that would solve this, but then leaves the question of what are we supposed to do to configure the two containers (the collector and jeager all in one) to do to talk?./
before it in the install which led to this error (users will still have this when pulling pre v0.1.1):