-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blog: IgnoreErrors and Az group command #1854
Conversation
2800c7c
to
80ddc7c
Compare
* Explain the new ignoreError feature in the exec mixin * Show how developers can use this functionality to create custom commands for this mixin. Signed-off-by: Carolyn Van Slyck <[email protected]>
80ddc7c
to
db34c53
Compare
Hey @squillace this was really bothering me the other day so I treated myself after coming back from vacation to adding error handling to the exec mixin. Take a look: https://deploy-preview-1854--porter.netlify.app/blog/ignoring-errors/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reads great! LGTM.
docs/content/blog/ignoring-errors.md
Outdated
## Try it out | ||
|
||
Bundle authors, try out moving some of that custom error handling logic out of bash scripts and move it into your exec mixin calls. | ||
Mixin authors, take a look at how the az mixin uses the exec mixin library to add error handling. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we link to the PR adding the logic in the az mixin? Or maybe source code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The more I thought about it the more I think that just looking at an existing mixin is pretty hard to figure out what's going on. I will hold off on the blog post and implement this stuff in skeletor with lots of comments so that we can point people to that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once getporter/skeletor#31 is merged I'll link to the source code that demonstrates how to do this in skeletor
Signed-off-by: Carolyn Van Slyck <[email protected]> Co-authored-by: Vaughn Dice <[email protected]>
Signed-off-by: Carolyn Van Slyck <[email protected]>
docs/content/blog/ignoring-errors.md
Outdated
--- | ||
|
||
When is an error not really an error? | ||
Questions like this come up regularly when automating deployments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this the question? (The when is an error not really an error) and more something like .. Why is my automated deployment erroring out when the resources exist? or something else. It's almost like when is an error not really an error is presupposing folks understanding what's up with the feature that based on me not being as steeped in what's going on with Porter really confused me at first by the title/description even.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll rework it so that it's less clever and more clear. 👍
Take another try at introducing the problem fixed by ignoreError Signed-off-by: Carolyn Van Slyck <[email protected]>
@iennae I've rewritten the introductory paragraph, what do you think? |
I'm going to ship this blog post since at this point the release is getting a bit old and I've already cut a new one yesterday. Hopefully my edits were sufficient 🤞 |
Oops just realized I'm still waiting for the PR to skeletor to be approved. 😇 |
Signed-off-by: Carolyn Van Slyck <[email protected]>
* Merge pull request getporter#1884 from carolynvs/blog-secret * Merge pull request getporter#1891 from carolynvs/survey * Blog: IgnoreErrors and Az group command (getporter#1854) * Merge pull request getporter#1871 from carolynvs/heading-spa * Merge pull request getporter#1861 from carolynvs/pr-checklis * Merge pull request getporter#1850 from carolynvs/link-v1-doc * Merge pull request getporter#1847 from mikebarkas/1845--anch * 1757 completion command (getporter#1844) * Merge pull request getporter#1839 from carolynvs/status-badg * docs: 1841 Fix typo and align template divs (getporter#1842) Signed-off-by: Carolyn Van Slyck <[email protected]>
What does this change
This adds a blog post about some new features in v1:
What issue does it fix
BLOG ALL THE THINGS!
Notes for the reviewer
I am going to tell people to make custom commands for mixins but we don't really have enough guidance for that yet. I've opened getporter/skeletor#29 to help address that.
Checklist