Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish: getsentry/[email protected] #4649

Closed
3 tasks
getsentry-release opened this issue Nov 23, 2024 · 10 comments
Closed
3 tasks

publish: getsentry/[email protected] #4649

getsentry-release opened this issue Nov 23, 2024 · 10 comments

Comments

@getsentry-release
Copy link

getsentry-release commented Nov 23, 2024

Requested by: @jamescrosswell

Merge target: (default)

Quick links:

Assign the accepted label to this issue to approve the release.
Leave a comment containing #retract under this issue to retract the release (original issuer only).

Targets

  • nuget
  • github
  • registry

Targets marked with a checkbox have already been executed. Administrators can manually tick a checkbox to force craft to skip it.

@bruno-garcia bruno-garcia added the accepted Add to approve the deploy label Nov 23, 2024
Copy link

Publishing: run#11991358537

@github-actions github-actions bot removed the accepted Add to approve the deploy label Nov 24, 2024
Copy link

Failed to publish. (run logs)

Bad branch? You can delete with ease and start over.

@bruno-garcia
Copy link
Member

STDOUT: dotnet: Pushing Sentry.Bindings.Android.5.0.0-alpha.0.nupkg to 'https://www.nuget.org/api/v2/package'...
dotnet:   PUT https://www.nuget.org/api/v2/package/
dotnet:   BadRequest https://www.nuget.org/api/v2/package/ 1343ms
dotnet: error: Response status code does not indicate success: 400 (The package is invalid and cannot be published. The package entry for 'Sentry.Bindings.Android.targets' has a  double forward slashes in path, which is causing a file name collision during extraction.).
dotnet: 

That's odd

@bruno-garcia bruno-garcia added the accepted Add to approve the deploy label Nov 24, 2024
@bruno-garcia
Copy link
Member

Don't think it's reentrant (nuget publish that is)

Copy link

Publishing: run#11991487490

Copy link

Failed to publish. (run logs)

Bad branch? You can delete with ease and start over.

@github-actions github-actions bot removed the accepted Add to approve the deploy label Nov 24, 2024
@bruno-garcia
Copy link
Member

bruno-garcia commented Nov 24, 2024

dotnet: To skip already published packages, use the option --skip-duplicate

Yeah we'd need to provide this to make this re-entrant.

But fails in the UI too:
Image

The file they say has "double forward slashes in path":

I mean it has the xmlns with http://.

<Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
  <ItemGroup>
    <ProguardConfiguration Include="$(MSBuildThisFileDirectory)..\..\proguard.cfg" />
  </ItemGroup>
</Project>

This has been there since the first version:
https://github.com/getsentry/sentry-dotnet/pull/2450/files#diff-a00f24179d4fb2ec1e497e77c12422251f15c3c2e62c9c5155eff83f57bc606f

@bruno-garcia
Copy link
Member

@jamescrosswell
Copy link

jamescrosswell commented Nov 24, 2024

STDOUT: dotnet: Pushing Sentry.Bindings.Android.5.0.0-alpha.0.nupkg to 'https://www.nuget.org/api/v2/package'...
dotnet: PUT https://www.nuget.org/api/v2/package/
dotnet: BadRequest https://www.nuget.org/api/v2/package/ 1343ms
dotnet: error: Response status code does not indicate success: 400 (The package is invalid and cannot be published. The package entry for 'Sentry.Bindings.Android.targets' has a double forward slashes in path, which is causing a file name collision during extraction.).
dotnet:

This is the diff between the v5.0.0 release and the v4.13.0 release:
Image

We did have a short conversation about the change on line 15 when it was made.

The error message is odd though. You might get a double forward slash from the old include (not the new one) if both $TargetFramework and $TargetPlatformVersion were blank. I can't see how that would be possible though.

@bruno-garcia
Copy link
Member

We'll make a new release with a fixed version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants