Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated monitoring yaml files #4433

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TheGreatDefector
Copy link

@TheGreatDefector TheGreatDefector commented Nov 22, 2024

Updated yml files, replacing "rss: null" with "rss: ~"

Resolves #4425

Updated yml files, replacing rss: null with rss: ~ as per issue

 getsolus#4425
@davidjharder
Copy link
Member

Hey, welcome to Solus! I changed your PR description so that the issue will be automatically closed.

@@ -1,6 +1,6 @@
releases:
id: 15257 # Check https://release-monitoring.org/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this file 15257 is correct, so please delete the rest of the line.

I can't find an rss feed, so leave rss: ~ and delete the rest of the line

@@ -1,6 +1,6 @@
releases:
id: 1866 # Check https://release-monitoring.org/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1866 is correct, so the rest of the line can be deleted

Copy link
Member

@davidjharder davidjharder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small corrections.

Also, please amend your commit title and PR title to something like repo-wide: Fix monitoring.yml files This is how we style commits that affect more than one package. If it was just one package, then it would be packagename: Fix monitoring.yml

@davidjharder
Copy link
Member

Hey @TheGreatDefector have you had time to look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Triage
Development

Successfully merging this pull request may close these issues.

Clean up some monitoring.ymls
2 participants