Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of supplementary alignments #45

Open
porchard opened this issue Jul 21, 2020 · 4 comments
Open

Handling of supplementary alignments #45

porchard opened this issue Jul 21, 2020 · 4 comments
Assignees
Labels
bug Something isn't working right Urgent High priority issues

Comments

@porchard
Copy link

Hi,

Thanks for the tool! I recently ran this on a large cohort and noticed some oddities in the output (e.g., end 1 mapping rates > 1 for a subset of the libraries). The issue seems to be attributable to a large number of supplementary alignments. As far as I can tell RNA-SeQC doesn't check the 0x800 flag denoting supplementary alignments and this throws off some of the numbers -- for example, inflating the 'unique mapping, vendor QC passed reads'.

Given the set of metrics that RNA-SeQC calculates, I would have expected it to exclude supplementary alignments from many of the metrics as it does for secondary alignments. Is there any particular reason for ignoring the supplementary alignment flag?

Happy to put together a pull request to treat supplementary alignments in a similar manner as secondary alignments, if you determine that to be desirable.

@agraubert
Copy link
Collaborator

Thank you for bringing this to our attention! We apologize for not catching this issue earlier. We're currently working on adding in an appropriate filter for supplementary reads and will keep you updated

@agraubert agraubert added bug Something isn't working right Urgent High priority issues labels Jul 21, 2020
@agraubert agraubert self-assigned this Jul 21, 2020
@porchard
Copy link
Author

That sounds great -- I'll look forward to the updated version, then!

@agraubert
Copy link
Collaborator

Just wanted to give you an update. We've updated the way RNA-SeQC counts chimeric reads and how it handles supplementary alignments. We're testing the new changes and expect to finalize the new changes soon

@porchard
Copy link
Author

Thanks! I'll give it a go once the changes are pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working right Urgent High priority issues
Projects
None yet
Development

No branches or pull requests

2 participants