Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faulty estimates of Read Length #77

Open
karl-az opened this issue Feb 16, 2023 · 1 comment
Open

Faulty estimates of Read Length #77

karl-az opened this issue Feb 16, 2023 · 1 comment

Comments

@karl-az
Copy link

karl-az commented Feb 16, 2023

I have noticed that RNA-seQC at times underestimates the Read Length

This is the section measuring read length:

rnaseqc/src/RNASeQC.cpp

Lines 274 to 277 in c426536

unsigned int alignmentSize = alignment.PositionEnd() - alignment.Position();
if (LegacyMode.Get() && alignmentSize > LEGACY_MAX_READ_LENGTH) continue;
if (!readLength) current_chrom = chromosomeMap(sequences[alignment.ChrID()].Name);
if (alignmentSize > readLength) readLength = alignment.Length();

The comparison is on alignmentSize, but the assignment is with alignment.Length(). Could this lead to unfortunate errors? Especially if alignment.Length() sometimes is less than alignmentSize

@kachulis
Copy link

kachulis commented Apr 7, 2023

I believe this is addressed by #78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants