Uncaught (in promise) TypeError: Failed to fetch

[yufeng1524]

Hi

we are using zipjs 2.6.63, and meet below error when zip file for sometimes, but not every time:

Uncaught (in promise) TypeError: Failed to fetch

webworker is configured for zipjs.

Additionally, we found there's same issue in #370 , and the issue has been fixed in 2.6.37 which is older than we used. And we didn't abort zip writer when meet the error.

Any idea about this issue?

[gildas-lormeau]

Why don't you use the last version?

[yufeng1524]

Why don't you use the last version?

thanks for quick responding.

by the way, is it a known issue?

[gildas-lormeau]

This issue should be fixed but it's a bit old. I guess the version 2.6.82 fixes your issue, see https://github.com/gildas-lormeau/zip.js/releases/tag/v2.6.82. It's very similar to the fix in the version 2.6.37, see 9ce18f6 (v2.6.82) and e8e5269 (v2.6.37).

[gildas-lormeau]

No, there's no real limitation, it's something that's managed by the environment. zip.js doesn't even know that a disk exists actually.

[tannerolsen7]

@gildas-lormeau I am still running into the same issues with the above suggestions.

        Promise.all(
            imgs.map(async (url) => {
                const imgReader = new HttpReader(url)
                await zipWriter.add(`${id}/${url}.jpg`, imgReader)
            })
        )

OR

            for (let url of imgs) {
                const imgReader = new HttpReader(url)
                await zipWriter.add(`${id}/${url}.jpg`, imgReader)
            }

To ensure it's not an issue from my end, is this what you meant?

[gildas-lormeau]

Indeed, I confirm this is what I meant. You could maybe optimize RAM usage by implementing your own Writer class or by relying on the WritableStream API instead of using BlobWriter (for zipFileBlob). To help you, I would need to know what you do with zipFileBlob (e.g. save on disk, upload on network). Also, what browser(s)/JS engine(s) must you support?

[yufeng1524]

Here is part of code, we add files in one zip one by one, and meet the exception : Uncaught (in promise) TypeError: Failed to fetch
could you help to take a look?

const zipJS = require('@zip.js/zip.js');
zipJS.configure({useWebWorkers: true});

writer = new zipJS.ZipWriter(new zipJS.BlobWriter());

await writer.add(fileName, new BufferReader(file))

class BufferReader extends zipJS.Uint8ArrayReader {
constructor(buffer) {
super(new Uint8Array(buffer));
}
}

[gildas-lormeau]

I'm sorry but I cannot help you. You did not answer to my question and the code does not give me any additional clue on what you do with zipFileBlob.

[gildas-lormeau]

I'm closing the Discussion because it should be an issue. If you create an issue, please provide detailed info about the issue.