-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial attempt at a portable MSYS2 #245
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Steve Lee [email protected]
sed 's/^[^ ]* //' | ||
} | ||
|
||
install_required () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't include the stuff about include despite upgrade as guessed it wouldn't be needed
|
||
SH_FOR_REBASE=dash | ||
|
||
BASE_PACKAGES="$(pacman -Qg base | awk '{print $2}' | tr '\n' ' ')" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Peobably don;t need all these. Possible remove via PACKAGE_EXCLUDES
# TODO need this? should be a parameter? Use BITNESS? | ||
PACKAGE_EXCLUDES="db info heimdal git util-linux curl git-for-windows-keyring | ||
mingw-w64-p11-kit filesystem msys2-launcher-git rebase" | ||
# TODO 05-home-dir.post required by filesystem package but is missing from SDK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason this file wanted but I was missing it in my SDK
PACKAGE_EXCLUDES="db info heimdal git util-linux curl git-for-windows-keyring | ||
mingw-w64-p11-kit filesystem msys2-launcher-git rebase" | ||
# TODO 05-home-dir.post required by filesystem package but is missing from SDK | ||
# TODO should we exlude all the tz stuff? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of stuff like perl (needed or git) Local and TZ files really bloat the zip but I don;t kno when might be needed
/mingw$BITNESS/libexec/git-core/git-update-git-for-windows" | ||
|
||
pacman_list $packages "$@" | | ||
grep -v -e '\.[acho]$' -e '\.l[ao]$' -e '/aclocal/' \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not clear if these filters are actually useful given my almost completely different package list
|
||
# Make the self-extracting package | ||
|
||
type 7za > /dev/null || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redirect to the old bit bucket
@@ -0,0 +1,106 @@ | |||
README.portable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops will need to rewrite this
grep --perl-regexp -v -e '^/usr/(lib|share)/terminfo/(?!.*/(cygwin|dumb|screen.*|xterm.*)$)' | | ||
sed 's/^\///' | ||
|
||
# TODO - need this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not at all sure why this is wanted
And shouldn't rebase be being run on 32 bit version?
-e '^/usr/share/vim/vim74/lang/' \ | ||
-e '^/etc/profile.d/git-sdk.sh$' | | ||
grep -v \ | ||
-e '^/mingw../share/locale/' \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can prolly ditch TZ stuff too
@@ -0,0 +1,153 @@ | |||
#!/bin/sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm - this shouldn't be here I guess. Not sure how it happened
echo 'GUIMode="1"' && | ||
echo 'InstallPath="%%S\\PortableMSYS2"' && | ||
echo 'OverwriteMode="0"' && | ||
echo "RunProgram=\"git-bash.exe --needs-console --hide --no-cd --command=post-install.bat\"" && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The existing post-install.bat looks good to me.
If you like feedback on tools. Getting |
Can we also make it portable between terminals? See https://stackoverflow.com/a/77877407/1540350 |
Lots of questions - inline comments in PR and
TODO
lines in files.Main question which packages to include as currently it's bigget than the G4W portable
Also need to be clear why this is better than just using MSYS2 - I think MinGW packages are used where possible so better performance. Is that right? What else?