Skip to content
This repository has been archived by the owner on Nov 14, 2019. It is now read-only.

README is misleading concerning sample rates #40

Open
Evertras opened this issue May 10, 2016 · 1 comment
Open

README is misleading concerning sample rates #40

Evertras opened this issue May 10, 2016 · 1 comment

Comments

@Evertras
Copy link

Hey there, Brubeck is pretty awesome! But for a while now we've been under the assumption that it didn't do anything with sample rates due to this line in the readme:

Client-sent sampling rates are ignored.

But after digging in the code to check something else, I noticed sample rates are supported when I send something like test:1|c|@0.1 and get a value of 10 on flush. Is this line in the README outdated or does it mean something else?

@vmg
Copy link
Contributor

vmg commented May 11, 2016

You're right! We've actually implemented that feature but forgot to update the README. 😓

I'll open a PR tomorrow morning. :)

ofosos pushed a commit to smaato/brubeck that referenced this issue May 18, 2018
Clearly state that sampling is supported.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants