Skip to content
This repository has been archived by the owner on Nov 14, 2019. It is now read-only.

Overflowing pickle write buffer as set in src/backends/carbon.h #48

Open
deanbittner opened this issue Sep 8, 2016 · 2 comments
Open

Comments

@deanbittner
Copy link

The default setting --

define PICKLE_BUFFER_SIZE 4096

Is too small, at least for me. I overflow it. I've built with a larger buffer, 16384, and no issues after that. The observed symptom is that all metrics are not visible and present in whisper, Graphite and downstream when I overwrite this buffer.

@vmg
Copy link
Contributor

vmg commented Sep 9, 2016

I'm not sure I understand the issue here; the buffer is checked for capacity before pushing new pickles, so it should not be possible to overflow it. Can you provide a reproduction recipe?

@deanbittner
Copy link
Author

Yes, I see that now ... I will take a closer look and see if I can get a test case going.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants