Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty if statement in article #35384

Closed
1 task done
akordowski opened this issue Nov 21, 2024 · 3 comments · Fixed by #35411
Closed
1 task done

Empty if statement in article #35384

akordowski opened this issue Nov 21, 2024 · 3 comments · Fixed by #35411
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team

Comments

@akordowski
Copy link
Contributor

Code of Conduct

What article on docs.github.com is affected?

Sharing actions and workflows with your organization

What part(s) of the article would you like to see updated?

The line 17 displayed below contains a empty if statement:

access a private {% ifversion internal-actions %} {% endif %}repository

docs/content/actions/sharing-automations/sharing-actions-and-workflows-with-your-organization.md

Lines 16 to 18 in 92260b1

You can share actions and reusable workflows within your organization, without publishing them publicly, by allowing {% data variables.product.prodname_actions %} workflows to access a private {% ifversion internal-actions %} {% endif %}repository that contains the action or reusable workflow.

I think it could be removed.

Additional information

I could provide a PR to fix it.
@akordowski akordowski added the content This issue or pull request belongs to the Docs Content team label Nov 21, 2024
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 21, 2024
@akordowski akordowski changed the title Empty ìf` statement in article Empty if statement in article Nov 21, 2024
@chan731126

This comment was marked as spam.

Sign in to view
@nguyenalex836 nguyenalex836 added actions This issue or pull request should be reviewed by the docs actions team and removed triage Do not begin working on this issue until triaged by the team labels Nov 21, 2024
@nguyenalex836
Copy link
Contributor

@akordowski I agree with you! Feel free to submit that PR whenever you have time 💛

@akordowski akordowski mentioned this issue Nov 25, 2024
Merged
2 tasks
@kai952700

This comment was marked as spam.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove empty if statement akordowski/github-docs
4 participants
@akordowski @kai952700 @nguyenalex836 @chan731126