Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create files base64 and sed errors #345

Closed
unaizorrilla opened this issue Nov 17, 2021 · 6 comments · Fixed by #351
Closed

Create files base64 and sed errors #345

unaizorrilla opened this issue Nov 17, 2021 · 6 comments · Fixed by #351

Comments

@unaizorrilla
Copy link

unaizorrilla commented Nov 17, 2021

Hi,

Reviewing the material for my acredition I discover two minor issues on create_files script, the first one is about base64 function, because on my machine ( WSL2 ) the $content generate a return line and the post file fail (400 bad request ) because invalid json.

The sed ejectued on non msys plattform is also malformed also (blank quotes) I fix both issues as I show on the code

        # Insert slide image into slide
        sed -i "s|IMAGE|$random_image|g" "$new_file" >>log.out 2>&1
        # Encode the file
        content=$(base64 -w 0 <"$new_file")
@unaizorrilla
Copy link
Author

If you are interested I can create PR with my changes,

@unaizorrilla
Copy link
Author

Well... another bug more on the scripts

  • on shared_functions the --quiet parameter for http is also not supported!

@parkerbxyz
Copy link
Contributor

Thanks for reporting this, @unaizorrilla. Feel free to open a pull request with your changes and we’ll review it.

@pamontag
Copy link

pamontag commented Feb 3, 2022

Well... another bug more on the scripts

  • on shared_functions the --quiet parameter for http is also not supported!

Hello, I had the same issue but the --quiet parameter is not supported for httpie 1.0.3 version that is shipped automatically on Ubuntu using apt-get in my environment. I solved installing httpie version 3.0.2 using snapd package manager but is not automatically managed by bootstrap script.

@amyschoen
Copy link
Collaborator

@pamontag, I ran into a similar issue around HTTPie version and filed #344.

@parkerbxyz
Copy link
Contributor

This issue will be automatically closed when #351 is merged. If the sed issue isn’t resolved, feel free to re-open this issue or create a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants