Skip to content
This repository has been archived by the owner on Apr 12, 2019. It is now read-only.

'tagger' value should be assigned to both Author and Committer probably #129

Open
SagePtr opened this issue Sep 19, 2018 · 0 comments
Open

Comments

@SagePtr
Copy link

SagePtr commented Sep 19, 2018

In cat-file output, regular commits have following keys:

author (one who wrote code and sent diff content)
committer (one who commited that code to repo or merged PR)

Tag commits have one key: tagger (which corresponds to user who made new tag)

Now, in repo_commit.go, function parseCommitData, tagger is assigned to commit.Author, and commit.Committer stays nil.

I think, for better compatibility, tagger should be assigned to both commit.Author and commit.Committer, because in this case tagger is both author of tag and committer of this tag.

This would also solve go-gitea/gitea#4961 issue when signatures are verified against Committer field, but Committer field is just nil for tag commit.

@SagePtr SagePtr changed the title 'tagger' value should be set to both Author and Committer probably 'tagger' value should be assigned to both Author and Committer probably Sep 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant