Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vue-tsc #32601

Merged
merged 2 commits into from
Nov 23, 2024
Merged

Add vue-tsc #32601

merged 2 commits into from
Nov 23, 2024
+147 −4

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Nov 21, 2024 •
edited
Loading

As per https://vuejs.org/guide/typescript/overview#overview, typescript's tsc does not support importing .vue files from .ts files, so we need to use vue-tsc which patches in that support. Added a convenience alias make tsc to run it.

@silverwind
Add vue-tsc
3b998a1 
As per https://vuejs.org/guide/typescript/overview#overview,
typescript's tsc does not support Vue SFC files, so we need to use
`vue-tsc` which does. Added a convenience alias `make tsc` to run it.
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 21, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 21, 2024
@silverwind silverwind added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Nov 21, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 23, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 23, 2024
@techknowlogick techknowlogick enabled auto-merge (squash) November 23, 2024 22:38
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 23, 2024
@techknowlogick techknowlogick merged commit fa175c1 into go-gitea:main Nov 23, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Nov 23, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/dependencies modifies/internal size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@silverwind @lunny @techknowlogick @GiteaBot