You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello everyone, and thank you for considering my proposal.
PROPOSAL:
This is a very small feature (explained below), that used to be the default functionality before
Godot 4.0. I'm not comfortable with c++, so I was hoping that someone with experience could either:
1) Add an Editor Setting to optionally restore the functionality OR
2) Revert the default functionality to what it used to be?
FUNCTIONALITY:
1) Use "ctr + shift + f" to run a "find in files" search for a text phrase
2) Click on any result displayed to jump to that location
3) Upon jumping to the text phrase location, the text phrase should be automatically highlighted in full.
Sometime around Godot 4, this was changed to place the cursor at the start of the text phrase,
without highlighting anything. I would prefer the phrase to be highlighted by default.
PURPOSE:
If I am changing text across many files, and I am unsure if my search may return results that
I do not want to change, I prefer to:
1) Jump to the text location
2) View the context of the phrase (2-3 seconds tops)
3) "ctrl + v" to paste changes once I'm sure the change is intended.
4) Jump to the next result, and repeat.
Having the phrase automatically selected means I don't need to manually highlight it to replace it,
which makes this iteration significantly faster and with fewer keystrokes.
I am aware of the "replace" functionality, and I use it when I'm confident of changes.
But manually iterating through results has its own benefits:
1) Gives me more assurance
2) Allows me to save changes to each file immediately
3) Keeps an undoable stack of changes inside the editor
CHANGE LOCATION:
I believe the change I'm looking for is at the following location:
"find_in_files.cpp"
line 857: void FindInFilesPanel::_on_result_selected()
line 869: emit_signal(SNAME(SIGNAL_RESULT_SELECTED), fpath, r.line_number, r.begin, r.end);
I suspect that r.end needs to span the length of the result, but r.end is == r.begin.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Hello everyone, and thank you for considering my proposal.
PROPOSAL:
This is a very small feature (explained below), that used to be the default functionality before
Godot 4.0. I'm not comfortable with c++, so I was hoping that someone with experience could either:
1) Add an Editor Setting to optionally restore the functionality OR
2) Revert the default functionality to what it used to be?
FUNCTIONALITY:
1) Use "ctr + shift + f" to run a "find in files" search for a text phrase
2) Click on any result displayed to jump to that location
3) Upon jumping to the text phrase location, the text phrase should be automatically highlighted in full.
Sometime around Godot 4, this was changed to place the cursor at the start of the text phrase,
without highlighting anything. I would prefer the phrase to be highlighted by default.
PURPOSE:
If I am changing text across many files, and I am unsure if my search may return results that
I do not want to change, I prefer to:
1) Jump to the text location
2) View the context of the phrase (2-3 seconds tops)
3) "ctrl + v" to paste changes once I'm sure the change is intended.
4) Jump to the next result, and repeat.
Having the phrase automatically selected means I don't need to manually highlight it to replace it,
which makes this iteration significantly faster and with fewer keystrokes.
I am aware of the "replace" functionality, and I use it when I'm confident of changes.
But manually iterating through results has its own benefits:
1) Gives me more assurance
2) Allows me to save changes to each file immediately
3) Keeps an undoable stack of changes inside the editor
CHANGE LOCATION:
I believe the change I'm looking for is at the following location:
"find_in_files.cpp"
line 857: void FindInFilesPanel::_on_result_selected()
line 869: emit_signal(SNAME(SIGNAL_RESULT_SELECTED), fpath, r.line_number, r.begin, r.end);
I suspect that r.end needs to span the length of the result, but r.end is == r.begin.
Thank you,
Ryan
Beta Was this translation helpful? Give feedback.
All reactions