Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vuln/cmd/govulncheck: unmask module versions in SBOM testdata #70523

Open
zpavlinovic opened this issue Nov 22, 2024 · 0 comments
Open

x/vuln/cmd/govulncheck: unmask module versions in SBOM testdata #70523

zpavlinovic opened this issue Nov 22, 2024 · 0 comments
Assignees
Labels
vulncheck or vulndb Issues for the x/vuln or x/vulndb repo

Comments

@zpavlinovic
Copy link
Contributor

zpavlinovic commented Nov 22, 2024

Go will soon release a feature where versions of the main module and dependencies built from an untagged or dirty commit produce a valid Go version. Before, those versions were (devel). The new change is already at go tip, making some of the tests fail that expect (devel) version. We currently mask the dirty versions with (devel) too, but when all builders' go versions have this feature, we should just use the actual version.

@zpavlinovic zpavlinovic self-assigned this Nov 22, 2024
@gopherbot gopherbot added the vulncheck or vulndb Issues for the x/vuln or x/vulndb repo label Nov 22, 2024
@gopherbot gopherbot modified the milestones: Unreleased, vuln/unplanned Nov 22, 2024
@zpavlinovic zpavlinovic changed the title x/vuln/cmd/govulncheck: unmask version of dependencies in SBOM x/vuln/cmd/govulncheck: unmask module versions in SBOM Nov 22, 2024
@zpavlinovic zpavlinovic changed the title x/vuln/cmd/govulncheck: unmask module versions in SBOM x/vuln/cmd/govulncheck: unmask module versions in SBOM testdata Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Projects
None yet
Development

No branches or pull requests

2 participants