Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken service traits in ApiDefinitionService #1056

Closed
afsalthaj opened this issue Nov 9, 2024 · 2 comments
Closed

Broken service traits in ApiDefinitionService #1056

afsalthaj opened this issue Nov 9, 2024 · 2 comments

Comments

@afsalthaj
Copy link
Contributor

For some reason, ApiDefinitionService as a type parameter was replaced with a concrete HttpApiDefinition.
While it's hard to convince the existence of a type parameterization, it's always a good practice to follow it.
@vigoo
Copy link
Contributor

vigoo commented Nov 28, 2024

Didn't you fix this already?

@vigoo
Copy link
Contributor

vigoo commented Dec 6, 2024

Closing this, code will be improved as part of other changes.

@vigoo vigoo closed this as completed Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vigoo @afsalthaj