From bbb7e81b55c5b6feee1e6f379e5a002163ea62f8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?D=C3=A1vid=20Istv=C3=A1n=20B=C3=ADr=C3=B3?= Date: Fri, 6 Sep 2024 07:56:59 +0200 Subject: [PATCH 1/3] clippy --- golem-test-framework/src/components/k8s.rs | 2 +- integration-tests/src/benchmarks/mod.rs | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/golem-test-framework/src/components/k8s.rs b/golem-test-framework/src/components/k8s.rs index 5784a067e..8b6d299e1 100644 --- a/golem-test-framework/src/components/k8s.rs +++ b/golem-test-framework/src/components/k8s.rs @@ -436,7 +436,7 @@ impl Routing { loop { let mut child = Command::new("minikube") .arg("service") - .arg(&format!("--namespace={}", namespace.0)) + .arg(format!("--namespace={}", namespace.0)) .arg("--url") .arg(service_name) .stdout(Stdio::piped()) diff --git a/integration-tests/src/benchmarks/mod.rs b/integration-tests/src/benchmarks/mod.rs index 40afd6836..9c249a9e8 100644 --- a/integration-tests/src/benchmarks/mod.rs +++ b/integration-tests/src/benchmarks/mod.rs @@ -176,7 +176,7 @@ pub async fn benchmark_invocations( result.retries as u64, ); recorder_clone.count( - &ResultKey::secondary(&format!("{prefix_clone}worker-{n}-retries")), + &ResultKey::secondary(format!("{prefix_clone}worker-{n}-retries")), result.retries as u64, ); recorder_clone.count( @@ -184,7 +184,7 @@ pub async fn benchmark_invocations( result.timeouts as u64, ); recorder_clone.count( - &ResultKey::secondary(&format!("{prefix_clone}worker-{n}-timeouts")), + &ResultKey::secondary(format!("{prefix_clone}worker-{n}-timeouts")), result.timeouts as u64, ); } From 51a460bb42d690f4eac9221fcb4f3aaf4b5db4dd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?D=C3=A1vid=20Istv=C3=A1n=20B=C3=ADr=C3=B3?= Date: Fri, 6 Sep 2024 08:01:10 +0200 Subject: [PATCH 2/3] remove printlns from ctors --- golem-common/src/tracing.rs | 4 +--- integration-tests/tests/lib.rs | 4 ---- integration-tests/tests/sharding.rs | 4 ---- 3 files changed, 1 insertion(+), 11 deletions(-) diff --git a/golem-common/src/tracing.rs b/golem-common/src/tracing.rs index ac97efbba..dd3068874 100644 --- a/golem-common/src/tracing.rs +++ b/golem-common/src/tracing.rs @@ -399,9 +399,7 @@ where }) }); - if config.dtor_friendly { - println!("Tracing initialized, config: {:?}", config); - } else { + if !config.dtor_friendly { info!( // NOTE: intentionally logged as string and not as structured tracing_config = serde_json::to_string(&config).expect("cannot serialize log config"), diff --git a/integration-tests/tests/lib.rs b/integration-tests/tests/lib.rs index 730bf9ab2..3ce59b256 100644 --- a/integration-tests/tests/lib.rs +++ b/integration-tests/tests/lib.rs @@ -34,10 +34,6 @@ pub static DEPS: EnvBasedTestDependencies = { let deps = EnvBasedTestDependencies::blocking_new_from_worker_executor_cluster_size(3); deps.redis_monitor().assert_valid(); - println!( - "Started a cluster of {} worker executors", - deps.worker_executor_cluster().size() - ); deps }; diff --git a/integration-tests/tests/sharding.rs b/integration-tests/tests/sharding.rs index 1730dda57..080ea19d0 100644 --- a/integration-tests/tests/sharding.rs +++ b/integration-tests/tests/sharding.rs @@ -671,10 +671,6 @@ pub static DEPS: EnvBasedTestDependencies = { }); deps.redis_monitor().assert_valid(); - println!( - "Started a cluster of {} worker executors", - deps.worker_executor_cluster().size() - ); deps }; From 7a7fe93e717fa962114d92c924488813ea08379f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?D=C3=A1vid=20Istv=C3=A1n=20B=C3=ADr=C3=B3?= Date: Fri, 6 Sep 2024 08:18:39 +0200 Subject: [PATCH 3/3] clippy --- golem-test-framework/src/components/k8s.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/golem-test-framework/src/components/k8s.rs b/golem-test-framework/src/components/k8s.rs index 8b6d299e1..be94846ce 100644 --- a/golem-test-framework/src/components/k8s.rs +++ b/golem-test-framework/src/components/k8s.rs @@ -492,7 +492,7 @@ impl Routing { loop { let output = Command::new("minikube") .arg("service") - .arg(&format!("--namespace={}", namespace.0)) + .arg(format!("--namespace={}", namespace.0)) .arg("--url") .arg(service_name) .output()