Fix CI and enable ninja-validations.sh #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ubuntu-22.04 (which is what ubuntu-latest is at the time of writing) now has clang++-14/clang-format-14 instead of 12. Update those and reformat files. Also, make our github action based on ubuntu-22.04 explicetly so that when latest changes we don't break again. (Although in scenarios like this we would still break) Also change a forward declaration to an include to resolve a build failure.
Update ninja to 1.11.1, which has validation actions, and enable ninja-validations.sh
lberki
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI was broken due to updates to the ubuntu docker image.
ninja-validations.sh can be enabled by updating ninja to the latest verision.