Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you support PSR Cache in version 3? #373

Closed
wlasnapl opened this issue Feb 9, 2022 · 8 comments
Closed

Can you support PSR Cache in version 3? #373

wlasnapl opened this issue Feb 9, 2022 · 8 comments
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@wlasnapl
Copy link

wlasnapl commented Feb 9, 2022

Is your feature request related to a problem? Please describe.
Some other vendor used in my project uses PSR cache in version 3 not in version 2 so there is conflict.

Describe the solution you'd like
Please support PSR Cache in version 3 also.

Describe alternatives you've considered
I've wrote also to that other vendor to support also version 2. But version 3 is newest so should be also supported by Google Auth

@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Feb 10, 2022
@wadewomersley
Copy link

Blocking upgrade to PHP8.1 due to this being the only library left that needs 1.0/2.0 and not 3.0.

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Feb 14, 2022
@wlasnapl
Copy link
Author

related PR: #364

@asurcodes
Copy link

In our case, this support is blocking us from adopting Firebase as a push notification service, we are up-to-date using PHP 8.1, so our main option is to use the legacy SERVER_KEY authentication mechanism, which is ironic...

IMO droping support for end-of-life PHP version in a new major release (#322) is the best move here, but is a bit worrying the lack of recent progress on the PR, I'm open to help if neccessary.

@janhenckens
Copy link

Running into similar (blocking) issues here, hope this can be resolved soon.

@bshaffer bshaffer added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Mar 23, 2022
@bshaffer
Copy link
Contributor

To implement 3.0 is not trivial - we'd have to either drop support for PHP < 8.0 (psr/cache 1.0 is not compatible with 3.0, and 2.0 requires at least PHP 8.0) which isn't going to happen, or create a TypedItem compatibility layer (see #364). In order to support the latter we'd need to drop support for PHP < 7.0, which is something I am willing to do at this point.

Thank you for your feedback.

@wadewomersley
Copy link

PHP 5.x has been EOL for a few years now (3yr2mo) so I think dropping support for it would certainly raise the least eyebrows.

@yoshi-automation yoshi-automation removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Mar 23, 2022
@bshaffer
Copy link
Contributor

I've updated the PR so the library has a minimum of PHP 7.1, and uses the TypedItem compatibility layer with psr 3.0.

Please use composer to try this branch out and see if it works for you

composer require google/auth:dev-add-typed-cache-item

@bshaffer
Copy link
Contributor

This is now released in v1.20.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

6 participants