Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(auth): ensure endpoints are present in Validator #11209

Merged
merged 2 commits into from
Dec 3, 2024
Merged

fix(auth): ensure endpoints are present in Validator #11209

merged 2 commits into from
Dec 3, 2024
+41 −25

Conversation

quartzmo
Copy link
Member

@quartzmo quartzmo commented Dec 3, 2024

fixes: #11190
fixes: #11189
fixes: #11188

@quartzmo quartzmo requested a review from a team as a code owner December 3, 2024 00:20
@quartzmo
Copy link
Member Author

quartzmo commented Dec 3, 2024

Please ignore the following apidiff error. The flagged change has not yet been released. The change from RSA256CertsURL to RS256CertsURL was made for naming consistency with "RS256 JWK".

- ./credentials/idtoken.ValidatorOptions.RSA256CertsURL: removed
- ```

codyoss
codyoss approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! TIL rs256 vs rsa256

@quartzmo quartzmo enabled auto-merge (squash) December 3, 2024 15:51
@quartzmo quartzmo merged commit 106cd53 into googleapis:main Dec 3, 2024
6 of 7 checks passed
@release-please release-please bot mentioned this pull request Dec 3, 2024
Open
@quartzmo quartzmo deleted the auth-idtoken-validate-fix branch December 3, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyoss codyoss codyoss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@quartzmo @codyoss