feat: introduce java.time
#2415
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
…ava-bigtable into introduce-java-time
…ds + nanos)" This reverts commit a7746ad.
diegomarquezp
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
diegomarquezp
commented
Nov 22, 2024
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/common/Type.java
Show resolved
Hide resolved
diegomarquezp
commented
Nov 22, 2024
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/sql/SqlType.java
Outdated
Show resolved
Hide resolved
diegomarquezp
commented
Nov 22, 2024
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/sql/Statement.java
Outdated
Show resolved
Hide resolved
diegomarquezp
commented
Nov 22, 2024
...rc/main/java/com/google/cloud/bigtable/data/v2/stub/RateLimitingServerStreamingCallable.java
Show resolved
Hide resolved
lqiu96
reviewed
Nov 25, 2024
...-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/retrying/RetryInfoRetryAlgorithm.java
Show resolved
Hide resolved
lqiu96
reviewed
Nov 25, 2024
google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableBackupIT.java
Outdated
Show resolved
Hide resolved
lqiu96
reviewed
Nov 26, 2024
...src/main/java/com/google/cloud/bigtable/data/v2/models/DefaultChangeStreamRecordAdapter.java
Outdated
Show resolved
Hide resolved
igorbernstein2
added
the
do not merge
no changes in admin, everything is reset to the latest of main
…ava-bigtable into introduce-java-time
product-auto-label
bot
added
size: m
lqiu96
approved these changes
Dec 6, 2024
diegomarquezp
removed
the
do not merge
mutianf
reviewed
Dec 10, 2024
| @@ -124,9 +123,10 @@ public void attemptCancelled() { | |||
| } | |||
| } | |||
|
|
|||
| public void attemptFailed(Throwable error, Duration delay) { | |||
There was a problem hiding this comment.
Instead of deleting this method, should attemptFailled call attemptFailedDuration?
| @@ -38,7 +38,7 @@ public class BigtableBatchingCallSettingsTest { | |||
| BatchingSettings.newBuilder() | |||
| .setElementCountThreshold(10L) | |||
| .setRequestByteThreshold(20L) | |||
| .setDelayThreshold(Duration.ofMillis(5)) | |||
There was a problem hiding this comment.
Im wondering if we should keep the test code the same so that we can verify these settings are ported to the new settings correctly? We can leave a todo to update them in a separate PR.
| @@ -149,11 +149,11 @@ public void testAttemptCancelled() { | |||
| public void testAttemptFailed() { | |||
| RuntimeException error = new RuntimeException(); | |||
| Duration delay = Duration.ofMillis(10); | |||
| compositeTracer.attemptFailed(error, delay); | |||
There was a problem hiding this comment.
same here, I think we should keep calling attemptFailed and verify attemptFailedDuration gets called?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
java.timealternatives to existingorg.threeten.bp.*methods, as well as switching internal variables (if any) tojava.timeThe main constraint is to keep the changes backwards compatible, so for each existing threeten method "
method1(org.threeten.bp.Duration)" we will add an alternative with a Duration (or Timestamp when applicable) suffix: "method1Duration(java.time.Duration)".For most cases, the implementation will be held in the
java.timemethod and the old threeten method will just delegate the call to it. However, for the case of abstract classes, the implementation will be kept in the threeten method to avoid breaking changes (i.e. users that already overloaded the method in their user code).Note: https://cloud.google.com/bigtable/docs/reference/sql/data-types#timestamp_type implies that nanosecond precision will be ignored.