Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add OpenTelemetry metrics to JDBC driver #351

Open
olavloite opened this issue Feb 12, 2021 · 0 comments
Open

feat: Add OpenTelemetry metrics to JDBC driver #351

olavloite opened this issue Feb 12, 2021 · 0 comments
Assignees
Labels
api: spanner Issues related to the googleapis/java-spanner-jdbc API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@olavloite
Copy link
Collaborator

The Cloud Spanner JDBC driver uses the Java client library for communication with Cloud Spanner, and all metrics that are defined in the client library are also used by the JDBC driver. The JDBC driver also adds some additional features that are not covered by the metrics in the Java client library, and could be added to the JDBC driver:

  • Transaction retries and aborted transactions: The JDBC driver implements an internal retry mechanism to reduce the number of Aborted errors for client applications. Metrics that measure the number of successful and failed retries could give clients valuable information on possible concurrency issues (or just temporary high load).
  • Writing mutations: The JDBC driver allows clients to use Mutations to write data to Cloud Spanner. This is not present in the JDBC specification, and will not be covered by any standard instrumentation for JDBC.
  • Transaction duration: JDBC uses declarative transactions and the duration of those are not measured by the client library. The JDBC driver could add a measurement for the duration of read/write transactions to allow clients to monitor for possibly long-during transactions.
@olavloite olavloite added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: spanner Issues related to the googleapis/java-spanner-jdbc API. labels Feb 12, 2021
@rajatbhatta rajatbhatta assigned olavloite and unassigned rajatbhatta Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner-jdbc API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants