Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Make usage example in samples consistent #2162

Closed

Conversation

gagangupt16
Copy link

@gagangupt16 gagangupt16 commented Oct 17, 2024

Fixes #2161 🦕

Gagan Gupta and others added 2 commits October 17, 2024 07:09
Currently, usage examples start in 2 ways
* `node samples/...`
* `node ...`

If all steps of Before you Begin section is followed, the latter with throw `MODULE_NOT_FOUND` error.
@gagangupt16 gagangupt16 requested review from a team as code owners October 17, 2024 08:19
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Oct 17, 2024
Copy link

Warning: This pull request is touching the following templated files:

@product-auto-label product-auto-label bot added api: spanner Issues related to the googleapis/nodejs-spanner API. samples Issues that are directly related to samples. labels Oct 17, 2024
@gagangupt16 gagangupt16 changed the title Consistent sample usage docs: Make usage example in samples consistent Oct 17, 2024
@surbhigarg92 surbhigarg92 added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 17, 2024
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 17, 2024
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 18, 2024
@surbhigarg92 surbhigarg92 added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 21, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 21, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 21, 2024
@product-auto-label product-auto-label bot added size: u Pull request is empty. and removed size: m Pull request size is medium. labels Oct 21, 2024
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. samples Issues that are directly related to samples. size: u Pull request is empty.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistent sample usage command in README.md
3 participants