Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

./cli.json on windows executable resolves to current working directory instead of path relative to .exe. #3

Open
Claudiohbsantos opened this issue Dec 28, 2018 · 7 comments
Labels

Comments

@Claudiohbsantos
Copy link

After running init and selecting to save the configs to ./cli.json the executable is unable to find the config file unless the console working directory is the executable's directory. In fact, I believe the ./cli.json file is saved to whichever working directory you have active when initis run.

Not sure if this is the intended functionality but I expected it to save to the same directory as the .exe file and to always be loaded from there regardless of my working directory.

As a temporary fix I created a batch script that I am using to call the cli app from anywhere with the expected behavior. I'm posting it here in case anyone finds this thread and needs an immediate fix.

gotify.bat
-----------------
@echo off
pushd %~dp0
Call %~dp0\gotify-cli-windows-amd64.exe p -q %* 
popd

The scripts needs to be placed on the same directory as the executable to work as is.

@jmattheis
Copy link
Member

Hey @Claudiohbsantos, I haven't really thought about this, but looking for the config file in the same dir as the executable seems like the better approach.

@doronbehar
Copy link

Here on Linux, I've encountered a related issue which was not present in previous versions. My always used ~/.gotify/cli.json is not read anymore and when I run gotify init it suggests to me to put the new cli.json either in /etc/gotify/cli.json or the current directory (./cli.json). I'm sorry but that just doesn't make sense..

Now I'm using /etc/gotify/cli.json but it would have been better to use the original, user owned ~/.config/gotify/cli.json.

@eternal-flame-AD
Copy link
Member

eternal-flame-AD commented Apr 26, 2019

I agree. @doronbehar

/cc @jmattheis

Are you interested in opening a PR for this? :)

@jmattheis
Copy link
Member

I think this is already fixed with 61a3e6c this isn't released yet, but I'll do this now.

@eternal-flame-AD
Copy link
Member

I think he was talking about making the user config directory as the default location to store config files.

@jmattheis
Copy link
Member

I think it is mainly about the ~/.config/gotify/cli.json configy. Since v2.0.0 the config was ignored (due to a bug) but this is now fixed in 2.1.0.

@eternal-flame-AD
Copy link
Member

Okay, I re-read the comment and it seems that you are right. I will open a new issue to track my proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

4 participants