-
-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When OAuth2 login is enabled, SERVER_SERVLET_SESSION_TIMEOUT seems not to take effect properly #1501
Comments
Does your browser clear cookies on restart maybe ? Session on client side is stored in cookies. Also, was the server restarted or was it running all the time ? Sessions are only stored in memory. |
If my browser clears cookies on every restart, then my SSO (Authelia) would also log out. |
I think I've found the reason. Following your suggestion, I checked the Cookies, and I found that after a successful login, Komga creates a cookie called |
not really relevant, since Mihon has credentials and will transparently login if needed. |
normally that shouldn't matter when remember-me is checked, but for OAuth2 i am not sure that would actually have any effect. There's a property I guess I could add support for this property, so if it is defined it would be used. I suppose that would address your concern ? |
Ideally the remember-me checkbox should apply to OAuth2, but it doesn't. I raised this spring-projects/spring-security#15078 let's see if that gets accepted or not. |
Thank you very much, but I don't think this issue is a critical one at the moment. So I think it's okay to wait for the result of spring-projects/spring-security#15078 before taking any action. There's no need to rush to add a temporary solution to Komga. I can try using some cookie management Chrome extensions as a temporary workaround. |
Steps to reproduce
Here is my application.yml file, which is almost identical to the example from Authelia, except that I added a session setting.
Expected behavior
server.servlet.session.timeout
works.Actual behavior
Every time I restart the browser, I need to sign in again.
Logs
No response
Komga version
v1.11.1-master
Operating system
Windows 11 & Chromium 124.0.6367.156-r1274542
Installation method
Docker
Other details
No response
Acknowledgements
The text was updated successfully, but these errors were encountered: