This repository has been archived by the owner on Aug 16, 2023. It is now read-only.
Give a useful error when no JVMCI version info can be retrieved #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougxc
reviewed
Feb 17, 2021
mx.jvmci/mx_jvmci.py
Outdated
| @@ -1463,6 +1463,8 @@ def _jvmci_versions_in_current_branch(): | |||
| m = jvmci_tag_re.match(decoration) | |||
| if m: | |||
| versions.append(tuple([int(g) for g in m.groups()])) | |||
| if not versions: | |||
| raise Exception('No JVMCI versions found. If this is a shallow clone of the git repo, it may need to be unshallowed and load tags with `git fetch --unshallow --tags`') | |||
There was a problem hiding this comment.
Looks good except that raise Exception should be mx.abort.
There was a problem hiding this comment.
Thanks. Changed, and force pushed.
The moment will be here for quite a while as stated in the release notes here. |
smarr
force-pushed
the
shallow-clone-issues
branch
from
ff302e2 to
293ce50
Compare
Signed-off-by: Stefan Marr <[email protected]>
smarr
force-pushed
the
shallow-clone-issues
branch
from
293ce50 to
f397d31
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi:
I just ran into an issue when trying to build this repo on MacOS (since there don't seem to be binaries at the moment).
Problem: I cloned with
git clone --depth 1, and got a index out of bounds on the JVMCI versions.The following patch gives a hint how to resolve it, though, it's probably not the best way.
And I don't know how mx usually communicates such errors.
Either suggestions welcome, or if you prefer, treat this simply as a "feature request".
Thanks!
/cc @dougxc