Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for reversible legend #85

Open
matschaffer opened this issue Dec 26, 2020 · 2 comments · May be fixed by #86
Open

Add option for reversible legend #85

matschaffer opened this issue Dec 26, 2020 · 2 comments · May be fixed by #86

Comments

@matschaffer
Copy link
Collaborator

matschaffer commented Dec 26, 2020

We have a panel up at https://grafana.safecast.cc/d/7wsttvxGk/safecast-airnote?orgId=1&var-device_urn=note:dev:864475041076562 and got feedback the legend seems backwards (low at the top, high at the bottom).

Screen Shot 2020-12-26 at 16 27 16

Pretty sure @nokton was expecting something like this (from @robouden)

legend

Looks like we can probably add .reverse() to https://github.com/panodata/grafana-map-panel/blob/5e7ae9fbebf0bd1cebd18e5c0a79c4e3217a1f42/src/worldmap.ts#L129 but might be better to make it an option if people prefer the current order.

@amotl
Copy link

amotl commented Dec 26, 2020

Dear Mat,

your suggestion looks very reasonable to me. We will be happy to accept further contributions around these details.

With kind regards,
Andreas.

matschaffer added a commit to matschaffer/worldmap-panel that referenced this issue Dec 27, 2020
@matschaffer matschaffer linked a pull request Dec 27, 2020 that will close this issue
@nokton
Copy link

nokton commented Dec 30, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants