-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.9.6 causes warning about buffering for binary mode #922
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Should be addressed |
I also see it on FreeBSD with python 3.8.12:
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This is a fix for Python 3.9.6 causes warning about buffering for binary mode graphite-project#922, setting this to 0 is the default behaviour and results in the default buffer size being used. The warning was released in Python 3.8.0 and is still present in 3.10.13 (tested, works and logging works fine) and is still present in 3.12.2 (https://github.com/python/cpython/blob/v3.12.2/Lib/_pyio.py#L231) The version check may be excessive because who would be running < 3.8.0, but you never know.
catching the same issue |
Running Carbon 1.1.8 is causing a warning when starting up under Python 3.9.6:
lib/python3.9/os.py:1023: RuntimeWarning: line buffering (buffering=1) isn't supported in binary mode, the default buffer size will be used
I believe the issue is caused by the "1" on this line:
carbon/lib/carbon/log.py
Line 24 in 9fad18d
The text was updated successfully, but these errors were encountered: