Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement request] Critical dependency: the request of a dependency is an expression #303

Open
matthewlilley opened this issue Oct 25, 2022 · 7 comments

Comments

@matthewlilley
Copy link

matthewlilley commented Oct 25, 2022

We use the generated SDK within multiple Next.js applications, and are seeing a lot of these messages.

Screenshot_62

How can these be avoided?

@ardatan
Copy link
Member

ardatan commented Oct 25, 2022

Are they preventing you to build the client? If no, you can ignore it.

@matthewlilley
Copy link
Author

@ardatan No, not at all. It's more of a nausiance. It clogs up terminal so makes debugging a little difficult.

@ardatan
Copy link
Member

ardatan commented Oct 26, 2022

It depends on your bundler. You can check the bundler's documentation for that.

@matthewlilley
Copy link
Author

matthewlilley commented Jun 14, 2023

I think this should be resolved on this end, and think this issue should stay open. Out of thousands of packages, the graph client is the only one which does this. Ignoring via webpack is an option but is a workaround rather than a real solution.

@ardatan ardatan changed the title Critical dependency: the request of a dependency is an expression [Improvement request] Critical dependency: the request of a dependency is an expression Jun 22, 2023
@ardatan ardatan reopened this Jun 22, 2023
@ardatan
Copy link
Member

ardatan commented Jun 22, 2023

Ok I'm reopening it but this is not a bug definitely. This has 0 effect on runtime or it doesn't block you from building the project.
Maybe we'll find a way to get rid of these false warnings from webpack.

@pugbyte
Copy link

pugbyte commented Jun 28, 2023

I have the same issue, does anyone know how to configure Webpack so that this warning goes away?

@LilaRest
Copy link

LilaRest commented Jul 6, 2023

Same issue here, and also interested in webpack configuration :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants