Update header, exact solution tols #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Header cleanup from upstream libmesh
This stems from update libmesh/@e8cec186f9206db4318ae50315e695d3413c0d9c where the default quadrature order for exact error estimation is updated to better approximate the higher order error terms. This ended up touching these tests so we update the error values accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some header cleanup upstream in libmesh we needed to account for in 7e3d4d5.
We also update some exact solution tolerances due to update libMesh/libmesh@e8cec18 which updated the default quadrature order in the exact solution error estimation. (
git bisect runis soooooo satisfying when it works)This now gets us passing all tests except the turbulence one, which is known in #622.