Skip to content

Latest commit

 

History

History
73 lines (47 loc) · 3.18 KB

README.md

File metadata and controls

73 lines (47 loc) · 3.18 KB
Raw

Gateway

Description

profile (dot) theguardian (dot) com

Gateway is the frontend to sign-in and registration at the Guardian at profile.theguardian.com.

Need help? Contact the Identity & Trust team on P&E/Identity & Trust.

Architecture/Overview

See the architecture doc.

Setup

A detailed setup guide can be found in docs/setup.

Quick Start

1. Environment Variables

Populate a .env file by using the examples from .env.example, or follow the instructions in docs/setup to download one from S3. The .env file should never be committed.

2. Running Locally

  1. Install dependencies and start development server:
$ make dev

On the first run, you may see errors in your console, this is because the build folder and project haven't finished compiling yet, just wait for a while for webpack to finish the bundling process.

Development Guides

Need help? Check the development guide first!

Other documentation in the docs folder.

Contributing

  1. Branch off of main, name your branch related to the feature you're implementing, prefix with your initials (e.g. mm/feature-name)
  2. Do your thing
  3. Ensure tests pass:
  • make ci or ./ci.sh
    • This runs linting, type-check, unit tests, build checks
  • make cypress-mocked or ./cypress-mocked
    • This runs Cypress integration tests against a mocked version of the Okta API
  • make cypress-ete or ./cypress-ete
    • This runs Cypress end-to-end tests against the Okta environment defined in .env
    • Be sure to use sparingly, this relies on Mailosaur which has a limited number of emails we can test with it each day
  • You can add -dev to the end of any of the above commands to run the tests against the development server. e.g. make cypress-ete-dev
  1. Make sure your branch is up to date with main
  • By merging or (preferably, if possible) rebasing onto main
  • This makes sure any conflicts are resolved prior to code review
  • If possible, please clean up the commit history to make each commit a clean change to make it more readable
    • e.g. for example when fixing things from a previous commit, or combining multiple commits into a single feature commit
    • git rebase -i <starting commit/branch name> e.g. git rebase -i origin/main
  1. Open a pull request
  • The template can be used for guidance on how to structure the PR, but you don't have to follow it.
  • Draft pull requests, and open pull requests with further pushed commits will not run the Chromatic and cypress-ete on each push/by default.
    • You have to manually opt into running these tests by either marking the draft PR as "Ready for review", or re-requesting a review (usually from "guardian/identity" or a previous reviewer)
    • This change was made to limit the number of builds to Chromatic and emails with Mailosaur to reduce costs with those products
  1. Code will be reviewed and require a 👍 from a team member before it will be merged
  2. When a PR is merged with main branch, it will ensure that the change is deployed to production.