Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cancel button to edit protest page #127

Closed
joeyede opened this issue Oct 12, 2020 · 6 comments · May be fixed by #213
Closed

Add cancel button to edit protest page #127

joeyede opened this issue Oct 12, 2020 · 6 comments · May be fixed by #213
Assignees
@CiTRuS93
Labels
good first issue Good for newcomers in progress level:easy This issue should be relatively easy to fix

Comments

@joeyede
Copy link
Collaborator

joeyede commented Oct 12, 2020

It would be much more elegent to have a button to allow you to cancel rather then just aborting mid edit if you change your mind.
@daganomri daganomri changed the title edit/add demonstratoin page needs a cancel button edit/add demonstration page needs a cancel button Oct 12, 2020
@uriklar uriklar self-assigned this Oct 14, 2020
@guytepper
Copy link
Owner

@joeyede Do you mean a button that acts like a 'back' button?

@joeyede
Copy link
Collaborator Author

joeyede commented Nov 8, 2020

yup. with clear message on edits will be lost.
It's not clear that the way to change your mind about editing is use the back button. People are used to a cancel option

@guytepper guytepper changed the title edit/add demonstration page needs a cancel button Add cancel button to edit protest page Nov 8, 2020
@guytepper guytepper added good first issue Good for newcomers level:easy This issue should be relatively easy to fix up for grabs labels Nov 8, 2020
@CiTRuS93
Copy link
Contributor

CiTRuS93 commented Nov 16, 2020 •
edited
Loading

Hey can I this? and if I can, what should be the text for the message?

@guytepper
Copy link
Owner

Hey @CiTRuS93, sure, it's yours :)
Let's use ביטול for the text.

@CiTRuS93
Copy link
Contributor

@guytepper
I was talking about confirmation massage, something like "edits will be lost"

@guytepper
Copy link
Owner

Let's avoid the confirmation message for now.

CiTRuS93 added a commit to CiTRuS93/1km.co.il that referenced this issue Nov 17, 2020
@CiTRuS93
guytepper#127 add cancel button
8e65077
@guytepper guytepper linked a pull request Nov 18, 2020 that will close this issue
#127 adding cancel button #213
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CiTRuS93 CiTRuS93

Labels
good first issue Good for newcomers in progress level:easy This issue should be relatively easy to fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#127 adding cancel button CiTRuS93/1km.co.il
4 participants
@uriklar @joeyede @CiTRuS93 @guytepper