-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xyzBuilder = channels: {..}
should be replaced with exports = channels: { packages = ...; apps = ...;}
#56
Comments
Looks good, let's make it |
I am definitely open to naming suggestions but i am not sure if {
# outputs #1
outputs = { self, utils, nixpkgs}@inputs:
utils.lib.systemFlake {
inherit self inputs;
# outputs #2
outputs = channels: {
# ...
};
};
} |
Oh true, I havn't seen that coming. Let's stick with "exports", then. |
Yeah I like it, the interface is much cleaner. exports = channels: lib.mergeAny {
packages = lib.builder.packagesFromOverlaysBuilderConstructor self.overlays channels;
} (otherArguments.exports channels); Also we should probably rename packagesFromOverlaysBuilderConstructor, and maybe the overlays exporter too. But we definitely need a different name for this than Random ideas:
I like outputsBuilder because it has a direct connection to the previous naming. |
Implemented in #59 |
I have no idea why fup does not implement just a single builder for everything - but now that I look at it - it's obvious that this would be quite a bit nicer way of handling things.
Possible issues:
Merging logic, it's always has been a pain. Tho if I recall correctly existing
mergeAny
function should just work out of the boxExpected outcome:
@blaggacao @Pacman99 Looks good?
The text was updated successfully, but these errors were encountered: