Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code organizing #368

Open
wants to merge 1 commit into
base: sprout
Choose a base branch
from
Open

code organizing #368

wants to merge 1 commit into from

Conversation

Connoropolous
Copy link
Contributor

No description provided.

@pospi
Copy link
Member

pospi commented Sep 13, 2022 •
edited
Loading

100% yes! This is cleanup that should've been done a while ago.

There are a couple of other things we can clean as well in this area.

  • All statically defined ByAddress structs should be replaced with a reference to the templatized one exported from hdk_semantic_indexes_zome_rpc via vf_attributes_hdk.
  • All use of the ByAction struct should be removed in favour of ByRevision, which makes more sense in the hdk_records context.
    • Additionally, any delete or update API calls that are passing address as the parameter in the GraphQL layer will need to pass revisionId instead. But, I don't think there are any of these. It may just be lingering in the Rust layer in inter-cell RPC calls (eg. Satisfaction)

@Connoropolous Connoropolous changed the title sample.. what do we think about moving Params structs to RPC crates? code organizing Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Connoropolous @pospi