-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pip3 install no longer adds executable to path #277
Comments
|
|
for scope, this is currently breaking our buildmaster as it |
python-poetry/poetry#927 seems relevant. (plus moving to a main.py?) For now I guess i'll just Reminder to remove my hack from the buildmaster :-) diff --git a/buildmaster/backend/Dockerfile b/buildmaster/backend/Dockerfile
index 3862d94..4e4ac55 100644
--- a/buildmaster/backend/Dockerfile
+++ b/buildmaster/backend/Dockerfile
@@ -30,6 +30,7 @@ RUN apt-get update \
&& wget https://github.com/jedisct1/minisign/releases/download/0.10/minisign-0.10-linux.tar.gz -O /tmp/minisign.tar.gz \
&& cd /tmp && tar -xvz --strip=2 -f /tmp/minisign.tar.gz && mv minisign /usr/local/bin \
&& pip3 install /tmp/haikuporter \
+ && echo "Bug #277 Fix" && cp /tmp/haikuporter/haikuporter.py /usr/local/bin/haikuporter \
&& cp /tmp/haikuporter/buildmaster/backend/assets/bin/* /usr/local/bin/ \
&& cp /tmp/haikuporter/buildmaster/backend/assets/bootstrap /bin/ \
&& cp /tmp/haikuporter/buildmaster/backend/assets/loop /bin/ \ |
* Ensure haikuporter cli is in path until tools.poetry is a little less melancholy
My uncultured stab at this: Adding a # -*- coding: utf-8 -*-
#
# Copyright 2013-2014 Oliver Tappe
# Distributed under the terms of the MIT License.
import logging
from .Main import Main
from .Options import parseOptions
def main():
logger = logging.getLogger("buildLogger")
logger.setLevel(logging.INFO)
logger.addHandler(logging.StreamHandler())
Main(*parseOptions()) and then adding the following to [tool.poetry.scripts]
haikuporter = "HaikuPorter.cli:main" Seems to work. I was able to build and install a .whl file using the > python3 -m build --wheel --no-isolation
* Getting build dependencies for wheel...
* Building wheel...
Successfully built haikuporter-1.2.8-py3-none-any.whl then I used Using This seems to allow to still use haikuporter.py (and its symlink) for those using it from a git clone, while should also work for installing either via pip, or with the build/installer modules (and would allow to resolve the TODO on HaikuPorter's recipe). [1] Poetry has way too many dependencies for my taste. Even so, after installing it in Haiku, running |
Adding additional file is not needed in this case. I need to check how it is building. Maybe some additional cleanup is needed here. |
After the changes @jurgenwigg put in place to modernize haikuporter,
pip3 install
no longer places haikuporter or haikuporter.py into a PATH. From what I can tell, it no longer even installs haikuporter.py anywhere.The text was updated successfully, but these errors were encountered: