Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: Configure groups in history page #32

Open
harsxv opened this issue Oct 9, 2024 · 5 comments · May be fixed by #33
Open

TODO: Configure groups in history page #32

harsxv opened this issue Oct 9, 2024 · 5 comments · May be fixed by #33
Assignees

Comments

@harsxv
Copy link
Owner

harsxv commented Oct 9, 2024

tinystatus/tinystatus.py

Lines 109 to 119 in 0b7536d

def update_history(results):
# TODO: Configure groups in history page
history = load_history()
current_time = datetime.now().isoformat()
for group in results.keys():
for check in results[group]:
if check['name'] not in history:
history[check['name']] = []
history[check['name']].append({'timestamp': current_time, 'status': check['status']})
history[check['name']] = history[check['name']][-MAX_HISTORY_ENTRIES:]
save_history(history)

@aarya-16
Copy link

aarya-16 commented Oct 9, 2024

Hello @harsxv I'd like to work on this. Can you assign it to me ?

@harsxv
Copy link
Owner Author

harsxv commented Oct 9, 2024

Hey, yeah sure. Assigned to you. Thanks!

@aarya-16 aarya-16 linked a pull request Oct 14, 2024 that will close this issue
@aarya-16
Copy link

Hey @harsxv I have made pull request #33 to address this issue.

@harsxv
Copy link
Owner Author

harsxv commented Oct 15, 2024

Hi @aarya-16, thank you! I've added some comments for you to review.

@aarya-16
Copy link

I've looked at the review @harsxv and have made the necessary changes.

@harsxv harsxv linked a pull request Oct 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants