Fix download and verify #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default axios responseType is 'json'. In this case we're downloading a text file (list of shasums) and a binary file (the signature), so different responeTypes are required.
The download method now waits until all data has been downloaded and written to the destination file. Before this, the method was resolved too early, and as a result, subsequent operations ran on an incomplete download. This caused operations like verify to fail, because of a different shasum.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
downloadmethod to wait until a download is finished before returning and fixes theverifymethod, which stopped working after the introduction of Axios in #11.It also adds more test cases to catch bugs like this earlier.