Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nomad-apm: add support to group nodes by datacenter #599

Open
jrasell opened this issue Sep 21, 2022 · 0 comments
Open

nomad-apm: add support to group nodes by datacenter #599

jrasell opened this issue Sep 21, 2022 · 0 comments

Comments

@jrasell
Copy link
Member

jrasell commented Sep 21, 2022

When expanding a nomad-apm short form query, the nomad-autoscaler will check if the target has node_class or datacenter set to expand the query. When expanding the query though, node_class is assumed and therefore makes the use of datacenter with the nomad-apm plugin impossible. The way in which the node pool query is generated will need to be changed to utilise this helper function. These changes should be enough to enable support.

We should also consider supporting the combined node pooling functionality, however, this will require additional changes to the query expansion than described above. Whoever implements the initial datacenter support should make this choice, and raise follow up issues as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant