Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Loggers should be consolidated between components and processes #15

Open
4 of 5 tasks
abelanger5 opened this issue Mar 14, 2023 · 0 comments
Open
4 of 5 tasks

Loggers should be consolidated between components and processes #15

abelanger5 opened this issue Mar 14, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@abelanger5
Copy link
Contributor

Location

  • Frontend
  • hatchet-server
  • hatchet-runner
  • hatchet-runner-worker
  • hatchet-temporal

Motivation

Different logging formats are used between the chi logging middleware, GORM, and temporal. All of these packages accept a custom logger implementation, so it should be fairly simple to consolidate the loggers to allow for both JSON and readable logs.

Requirements

  • Pass Hatchet logger to:
    • GORM
    • Chi logging middleware (might have to write custom logging middleware)
    • Temporal
  • Make sure debug log level is respected (particularly by GORM)
  • Print stack traces on error logs
  • Update logging implementation to generate readable logs for testing/development

Additional Details

@abelanger5 abelanger5 added the enhancement New feature or request label Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant