Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headers overriding #30

Open
AILazerka opened this issue Oct 4, 2017 · 4 comments
Open

Headers overriding #30

AILazerka opened this issue Oct 4, 2017 · 4 comments
Labels
Milestone

Comments

@AILazerka
Copy link

AILazerka commented Oct 4, 2017

Hello!

When implementing service for backend requests I've found out that it'll be great to have feature when you're adding Headers decorator to the method with an opportunity to override headers from DefaultHeaders which are on class. Mostly I'm using application/json as the Content-Type but for several methods I want to use another. Currently ng2-http is appending existing comma-separated list of values in one string.

p.s. it's a suggestion for improvement

@AILazerka AILazerka reopened this Oct 4, 2017
@hboylan
Copy link
Owner

hboylan commented Oct 4, 2017

Good catch. The intended use case is for local headers to override the defaults. If that’s not happening already this is definitely a bug

@AILazerka
Copy link
Author

As far as I understood from sources only appending is applied but no replacing. But can be wrong.
Doesn't work anyways))

@hboylan
Copy link
Owner

hboylan commented Oct 4, 2017

Thanks, I’ll investigate

@AILazerka
Copy link
Author

Thank you very much!!!

@hboylan hboylan added the bug label Oct 4, 2017
@hboylan hboylan added this to the 1.1.0 milestone Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants