Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support darwin-arm64 #19

Closed
andypiper opened this issue Jan 11, 2022 · 5 comments
Closed

Support darwin-arm64 #19

andypiper opened this issue Jan 11, 2022 · 5 comments

Comments

@andypiper
Copy link

Running gh upgrade --all reports:

[graph]: already up to date
[label]: gh-label unsupported for darwin-arm64. Open an issue: `gh issue create -R heaths/gh-label -t'Support darwin-arm64'`
[markdown-preview]: upgrade complete

... so, raiding this issue!

@heaths
Copy link
Owner

heaths commented Jan 11, 2022

Thanks for the suggestion! I currently use https://github.com/cli/gh-extension-precompile to compile and publish the binaries, so you'll need to file a feature request there. The https://github.com/cli/cli will also likely need a change to check for and download darwin-arm64 releases as well.

/cc @vilmibm

@heaths heaths closed this as completed Jan 11, 2022
@heaths
Copy link
Owner

heaths commented Jan 11, 2022

There's a PR already available, but waiting for cli/cli changes: cli/gh-extension-precompile#3

@mislav
Copy link

mislav commented Apr 13, 2022

The latest GitHub CLI 2.8.0 release fixes this by falling back to amd64 binary if Rosetta is installed. If an arm64 binary is found, for example as a product of the latest gh-extension-precompile action, however, then its codesigning is fixed after downloading to allow execution by the OS.

@heaths
Copy link
Owner

heaths commented Apr 13, 2022

@mislav so if I understand you correctly, if we can't/won't sign our arm64 binaries we should not upgrade to the latest gh-extension-precompile action?

@mislav
Copy link

mislav commented Apr 21, 2022

@heaths We can not expect that every extension author signs their arm64 binaries since that (to my knowledge) would require them to have a paid Apple Developer account. So, your binaries can remain unsigned; gh v2.8+ will self-sign any downloaded arm64 extension during installation. You can safely upgrade to the latest gh-extension-precompile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants