Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vertical scrolling over Helm docs. #1464

Open
jmrnilsson opened this issue May 6, 2023 · 5 comments · May be fixed by #1535
Open

Vertical scrolling over Helm docs. #1464

jmrnilsson opened this issue May 6, 2023 · 5 comments · May be fixed by #1535
Labels
bug

Comments

@jmrnilsson
Copy link

The docs over at https://helm.sh/docs/intro/cheatsheet/ has a transient error so it doesn’t allow for scrolling up or down on IOS Safari. It’s pretty bad.

Same goes for Firefox on IOS..
@jmrnilsson jmrnilsson mentioned this issue May 6, 2023
Closed
@angellk
Copy link
Contributor

angellk commented May 8, 2023

Thanks for bringing this up - do you have cycles to look at this @jmrnilsson ?

@z4ce
Copy link

z4ce commented May 8, 2023 •
edited
Loading

It seems to be something with the way the nav bar is scrolling and the behavior seems to be across all docs. I recorded this in Chrome set to iPhone 12, but it seems to do the same thing in Safari on iOS. Scrolling once seems to move the nav bar down, then scrolling again seems to allow the content to scroll

Screen.Recording.2023-05-08.at.11.56.08.AM.mov

@jmrnilsson
Copy link
Author

Yeah, thanks for the update while I was away. I concur with z4ce, this applies to Safari/FF on IOS on IPhone 2022 SE and IPhone 11. Probably IPhone 12 as well as written above.

Normally I wouldn’t bother. But it renders the docs unreadable. Annoyingly only occurs transiently.

@jmrnilsson
Copy link
Author

I cannot se the video for some reason. But it should be pretty self-evident once it occurs.

@antdking
Copy link

antdking commented Jun 20, 2023 •
edited
Loading

This also affects Firefox on Android, though looks to hitch less often based on the above video.

Dupe of #1393; appears to impact safari, chromium and Firefox on ios + android

@scottrigby scottrigby added the bug label Nov 17, 2023
lightster added a commit to lightster/helm-www that referenced this issue Dec 9, 2023
@lightster
Fix web site scrolling on mobile browsers
7bd3411 
Scrolling pages on the Helm web site is difficult on mobile devices due
to nested scrolling containers. This changeset removes the nested
scrolling containers.

The fix to remove the nested scrolling containers caused pages to start
scrolling horizontally because the content of the pages have negative
margins, which makes the page wider than 100%. The rest of this
changeset addresses the negative margins by removing them and/or
offsetting them in each element that was causing the page to horizontal
scroll.

Fixes helm#741
Fixes helm#1393
Fixes helm#1464

Signed-off-by: Matt Light <[email protected]>
@lightster lightster linked a pull request Dec 9, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix web site scrolling on mobile browsers lightster/helm-www
5 participants
@scottrigby @angellk @antdking @z4ce @jmrnilsson